lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKYAXd_SGcWj74VpeqVzCVpBn2OxZv9tdW6XHudHOwGY_v_GBQ@mail.gmail.com>
Date: Thu, 27 Nov 2025 21:18:37 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Amir Goldstein <amir73il@...il.com>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@...radead.org, hch@....de, 
	tytso@....edu, willy@...radead.org, jack@...e.cz, djwong@...nel.org, 
	josef@...icpanda.com, sandeen@...deen.net, rgoldwyn@...e.com, 
	xiang@...nel.org, dsterba@...e.com, pali@...nel.org, ebiggers@...nel.org, 
	neil@...wn.name, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com, gunho.lee@....com
Subject: Re: [PATCH v2 11/11] ntfsplus: add Kconfig and Makefile

On Thu, Nov 27, 2025 at 6:31 PM Amir Goldstein <amir73il@...il.com> wrote:
>
> On Thu, Nov 27, 2025 at 6:01 AM Namjae Jeon <linkinjeon@...nel.org> wrote:
> >
> > This adds the Kconfig and Makefile for ntfsplus.
>
> MAINTAINERS?
Okay, I will add it on next version:)
Thanks!
>
> >
> > Signed-off-by: Namjae Jeon <linkinjeon@...nel.org>
> > ---
> >  fs/Kconfig           |  1 +
> >  fs/Makefile          |  1 +
> >  fs/ntfsplus/Kconfig  | 45 ++++++++++++++++++++++++++++++++++++++++++++
> >  fs/ntfsplus/Makefile | 18 ++++++++++++++++++
> >  4 files changed, 65 insertions(+)
> >  create mode 100644 fs/ntfsplus/Kconfig
> >  create mode 100644 fs/ntfsplus/Makefile
> >
> > diff --git a/fs/Kconfig b/fs/Kconfig
> > index 0bfdaecaa877..70d596b99c8b 100644
> > --- a/fs/Kconfig
> > +++ b/fs/Kconfig
> > @@ -153,6 +153,7 @@ menu "DOS/FAT/EXFAT/NT Filesystems"
> >  source "fs/fat/Kconfig"
> >  source "fs/exfat/Kconfig"
> >  source "fs/ntfs3/Kconfig"
> > +source "fs/ntfsplus/Kconfig"
> >
> >  endmenu
> >  endif # BLOCK
> > diff --git a/fs/Makefile b/fs/Makefile
> > index e3523ab2e587..2e2473451508 100644
> > --- a/fs/Makefile
> > +++ b/fs/Makefile
> > @@ -91,6 +91,7 @@ obj-y                         += unicode/
> >  obj-$(CONFIG_SMBFS)            += smb/
> >  obj-$(CONFIG_HPFS_FS)          += hpfs/
> >  obj-$(CONFIG_NTFS3_FS)         += ntfs3/
> > +obj-$(CONFIG_NTFSPLUS_FS)      += ntfsplus/
> >  obj-$(CONFIG_UFS_FS)           += ufs/
> >  obj-$(CONFIG_EFS_FS)           += efs/
> >  obj-$(CONFIG_JFFS2_FS)         += jffs2/
> > diff --git a/fs/ntfsplus/Kconfig b/fs/ntfsplus/Kconfig
> > new file mode 100644
> > index 000000000000..c13cd06720e7
> > --- /dev/null
> > +++ b/fs/ntfsplus/Kconfig
> > @@ -0,0 +1,45 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +config NTFSPLUS_FS
> > +       tristate "NTFS+ file system support"
> > +       select NLS
> > +       help
> > +         NTFS is the file system of Microsoft Windows NT, 2000, XP and 2003.
> > +         This allows you to mount devices formatted with the ntfs file system.
> > +
> > +         To compile this as a module, choose M here: the module will be called
> > +         ntfsplus.
> > +
> > +config NTFSPLUS_DEBUG
> > +       bool "NTFS+ debugging support"
> > +       depends on NTFSPLUS_FS
> > +       help
> > +         If you are experiencing any problems with the NTFS file system, say
> > +         Y here.  This will result in additional consistency checks to be
> > +         performed by the driver as well as additional debugging messages to
> > +         be written to the system log.  Note that debugging messages are
> > +         disabled by default.  To enable them, supply the option debug_msgs=1
> > +         at the kernel command line when booting the kernel or as an option
> > +         to insmod when loading the ntfs module.  Once the driver is active,
> > +         you can enable debugging messages by doing (as root):
> > +         echo 1 > /proc/sys/fs/ntfs-debug
> > +         Replacing the "1" with "0" would disable debug messages.
> > +
> > +         If you leave debugging messages disabled, this results in little
> > +         overhead, but enabling debug messages results in very significant
> > +         slowdown of the system.
> > +
> > +         When reporting bugs, please try to have available a full dump of
> > +         debugging messages while the misbehaviour was occurring.
> > +
> > +config NTFSPLUS_FS_POSIX_ACL
> > +       bool "NTFS+ POSIX Access Control Lists"
> > +       depends on NTFSPLUS_FS
> > +       select FS_POSIX_ACL
> > +       help
> > +         POSIX Access Control Lists (ACLs) support additional access rights
> > +         for users and groups beyond the standard owner/group/world scheme,
> > +         and this option selects support for ACLs specifically for ntfs
> > +         filesystems.
> > +         NOTE: this is linux only feature. Windows will ignore these ACLs.
> > +
> > +         If you don't know what Access Control Lists are, say N.
> > diff --git a/fs/ntfsplus/Makefile b/fs/ntfsplus/Makefile
> > new file mode 100644
> > index 000000000000..1e7e830dbeec
> > --- /dev/null
> > +++ b/fs/ntfsplus/Makefile
> > @@ -0,0 +1,18 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# Makefile for the ntfsplus filesystem support.
> > +#
> > +
> > +# to check robot warnings
> > +ccflags-y += -Wint-to-pointer-cast \
> > +        $(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
> > +        $(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)
> > +
> > +obj-$(CONFIG_NTFSPLUS_FS) += ntfsplus.o
> > +
> > +ntfsplus-y := aops.o attrib.o collate.o misc.o dir.o file.o index.o inode.o \
> > +         mft.o mst.o namei.o runlist.o super.o unistr.o attrlist.o ea.o \
> > +         upcase.o bitmap.o lcnalloc.o logfile.o reparse.o compress.o \
> > +         ntfs_iomap.o
> > +
> > +ccflags-$(CONFIG_NTFSPLUS_DEBUG) += -DDEBUG
> > --
> > 2.25.1
> >

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ