linux-kernel - [PATCH] ksmbd: Add check in cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251127122637.2094566-1-aadityakansal390@gmail.com>
Date: Thu, 27 Nov 2025 17:56:37 +0530
From: Aaditya Kansal <aadityakansal390@...il.com>
To: sfrench@...ba.org,
	pc@...guebit.org
Cc: ronniesahlberg@...il.com,
	sprasad@...rosoft.com,
	tom@...pey.com,
	linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	bharathsm@...rosoft.com,
	skhan@...uxfoundation.org,
	david.hunter.linux@...il.com,
	Aaditya Kansal <aadityakansal390@...il.com>
Subject: [PATCH] ksmbd: Add check in cifs_mkdir() for SMB2/3

Add a version check in cifs_mkdir(). The check skips a function call to
cifs_mkdir_qinfo() for SMB 2/3.

Signed-off-by: Aaditya Kansal <aadityakansal390@...il.com>
---
 fs/smb/client/inode.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c
index cac355364e43..f6f223a5a97b 100644
--- a/fs/smb/client/inode.c
+++ b/fs/smb/client/inode.c
@@ -2314,9 +2314,9 @@ struct dentry *cifs_mkdir(struct mnt_idmap *idmap, struct inode *inode,
 		goto mkdir_out;
 	}
 
-	/* TODO: skip this for smb2/smb3 */
-	rc = cifs_mkdir_qinfo(inode, direntry, mode, full_path, cifs_sb, tcon,
-			      xid);
+	if (server->vals->protocol_id == SMB10_PROT_ID)
+		rc = cifs_mkdir_qinfo(inode, direntry, mode, full_path, cifs_sb,
+				tcon, xid);
 mkdir_out:
 	/*
 	 * Force revalidate to get parent dir info when needed since cached
-- 
2.52.0