linux-kernel - Re: [PATCH] zram: Remove KMSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4q7n6k623tz5xvg3or7l5pcuiq2kd2gk4gezzfmnw5eelvou6e@kgsakiwwztxn>
Date: Thu, 27 Nov 2025 10:50:36 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Andrew Morton <akpm@...ux-foundation.org>, 
	Heiko Carstens <hca@...ux.ibm.com>
Cc: Jens Axboe <axboe@...nel.dk>, Minchan Kim <minchan@...nel.org>, 
	Sergey Senozhatsky <senozhatsky@...omium.org>, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] zram: Remove KMSG_COMPONENT macro

Adding Andrew (message id: 20251126143602.2207435-1-hca@...ux.ibm.com)

On (25/11/26 15:36), Heiko Carstens wrote:
> The KMSG_COMPONENT macro is a leftover of the s390 specific "kernel message
> catalog" from 2008 [1] which never made it upstream.
> 
> The macro was added to s390 code to allow for an out-of-tree patch which
> used this to generate unique message ids. Also this out-of-tree doesn't
> exist anymore.
> 
> The pattern of how the KMSG_COMPONENT is used was partially also used for
> non s390 specific code, for whatever reasons.
> 
> Remove the macro in order to get rid of a pointless indirection.
> 
> [1] https://lwn.net/Articles/292650/
> 
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>

Reviewed-by: Sergey Senozhatsky Sergey Senozhatsky <senozhatsky@...omium.org>

> ---
>  drivers/block/zram/zram_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index a43074657531..4ea0d435a24e 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -12,8 +12,7 @@
>   *
>   */
>  
> -#define KMSG_COMPONENT "zram"
> -#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
> +#define pr_fmt(fmt) "zram: " fmt
>  
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -- 
> 2.51.0
>