linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: enable NPU on rk3588-jaguar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d9ef351-9eb9-41b1-beff-7a1deb73927b@cherry.de>
Date: Thu, 27 Nov 2025 14:28:58 +0100
From: Quentin Schulz <quentin.schulz@...rry.de>
To: Heiko Stuebner <heiko@...ech.de>
Cc: linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Heiko Stuebner <heiko.stuebner@...rry.de>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: enable NPU on rk3588-jaguar

Hi Heiko,

On 8/12/25 10:52 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
> 
> Enable the NPU cores and their mmus and wire up the supply-regulator.
> The regulator itself was already defined, but it does not need to be
> always on - the npu can control it.
> 

My apologies for the time it took me to review and test this.

I tested with aarch64 defconfig + DRM_ACCEL_ROCKET=m loosely following 
the instructions from https://docs.mesa3d.org/teflon.html and the script 
finishes, so I guess that means it works.

I have managed to get an Oops with another defconfig, but that is not 
related to DT so not a blocker for merging this.

Thus:

Reviewed-by: Quentin Schulz <quentin.schulz@...rry.de>
Tested-by: Quentin Schulz <quentin.schulz@...rry.de>

Note that I have the same remark about regulator-boot-on property in 
vdd_npu_s0 I made[1] for Tiger here.

[1] 
https://lore.kernel.org/linux-rockchip/d784230e-49f4-49e9-be4a-bc7c00020cfb@cherry.de/

Thanks!
Quentin