linux-kernel - Re: [PATCH net] net: phy: aquantia: check for NVMEM deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aShSesEATBaKnO0A@shell.armlinux.org.uk>
Date: Thu, 27 Nov 2025 13:30:34 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Robert Marko <robimarko@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	ansuelsmth@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: aquantia: check for NVMEM deferral

On Thu, Nov 27, 2025 at 12:44:35PM +0100, Robert Marko wrote:
> Currently, if NVMEM provider is probed later than Aquantia, loading the
> firmware will fail with -EINVAL.
> 
> To fix this, simply check for -EPROBE_DEFER when NVMEM is attempted and
> return it.
> 
> Fixes: e93984ebc1c8 ("net: phy: aquantia: add firmware load support")
> Signed-off-by: Robert Marko <robimarko@...il.com>

As aqr_firmware_load() is called from the probe function, returning
-EPROBE_DEFER from here is fine.

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!