linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: qcom,snps-dwc3: Add support for firmware-managed resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44593251-795c-4009-8202-06688027e150@kernel.org>
Date: Thu, 27 Nov 2025 14:56:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sriram Dash <sriram.dash@....qualcomm.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Wesley Cheng <quic_wcheng@...cinc.com>,
 Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc: jack.pham@....qualcomm.com, faisal.hassan@....qualcomm.com,
 krishna.kurapati@....qualcomm.com, andersson@...nel.org,
 linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: usb: qcom,snps-dwc3: Add support for
 firmware-managed resources

On 27/11/2025 13:13, Krzysztof Kozlowski wrote:
> On 27/11/2025 11:31, Sriram Dash wrote:
>> On Qualcomm automotive SoC sa8255p, platform resources like clocks,
>> interconnect, resets, regulators and GDSC are configured remotely by
>> firmware.
>>
>> PM OPP is used to abstract these resources in firmware and SCMI perf
>> protocol is used to request resource operations by using runtime PM
>> framework APIs such as pm_runtime_get/put_sync to signal firmware
>> for managing resources accordingly for respective perf levels.
>>
>> "qcom,snps-dwc3-fw-managed" compatible helps determine if
>> the device's resources are managed by firmware.
>> Additionally, it makes the power-domains property mandatory
>> and excludes the clocks property for the controller.
>>
>> Signed-off-by: Sriram Dash <sriram.dash@....qualcomm.com>
>> ---
>>  .../devicetree/bindings/usb/qcom,snps-dwc3.yaml    | 173 +++++++++++++--------
>>  1 file changed, 111 insertions(+), 62 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> index 8cee7c5582f2..d2d1b42fbb07 100644
>> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> @@ -12,68 +12,65 @@ maintainers:
>>  description:
>>    Describes the Qualcomm USB block, based on Synopsys DWC3.
>>  
>> -select:
>> -  properties:
>> -    compatible:
>> -      contains:
>> -        const: qcom,snps-dwc3
>> -  required:
>> -    - compatible
> 
> I wonder why do you think dropping some code is fine...
> 
> 
>> +      - items:
>> +          - enum:
>> +              - qcom,sa8255p-dwc3
>> +          - const: qcom,snps-dwc3-fw-managed
> 
> No, you cannot keep coming with more generic compatibles.
> 
> If you want generic a compatible, you already have - qcom,snps-dwc3 -
> and that "generic" part already said that everything is compatible with it.
> 
> Now you claim that existing generic compatible qcom,snps-dwc3 is not
> generic enough and you need one more generic compatible.
> 
> Next year you will say that two generic compatibles are not generic
> enough and you need third generic compatible.
> 
> In two years we will learn that three generic compatibles are not enough...
> 
> I think I was complaining on the lists a lot on this, so I am surprised
> it is still coming back.
> 
> So no, you cannot claim that you need more generic compatibles because
> one generic is not generic. NAK.


What is even weirder is that other patchset for the same SA8255 FW
managed IP block correctly ignored generic compatible:
https://lore.kernel.org/all/20251114145646.2291324-3-ram.dwivedi@oss.qualcomm.com/

so somehow you should meet and align on common understanding of things.
Please do not send completely different patches for the same problem.

Best regards,
Krzysztof