linux-kernel - Re: [RFC PATCH v2 2/2] ARM/mm/fault: Enable interrupts before sending signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251127144913.arc7keYZ@linutronix.de>
Date: Thu, 27 Nov 2025 15:49:13 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Xie Yuanbin <xieyuanbin1@...wei.com>
Cc: viro@...iv.linux.org.uk, will@...nel.org, nico@...xnic.net,
	rmk+kernel@...linux.org.uk, linux@...linux.org.uk,
	david.laight@...box.com, rppt@...nel.org, vbabka@...e.cz,
	pfalcato@...e.de, brauner@...nel.org, lorenzo.stoakes@...cle.com,
	kuninori.morimoto.gx@...esas.com, tony@...mide.com, arnd@...db.de,
	akpm@...ux-foundation.org, punitagrawal@...il.com, hch@....de,
	jack@...e.com, rjw@...ysocki.net, marc.zyngier@....com,
	linux-arm-kernel@...ts.infradead.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	wozizhi@...weicloud.com, liaohua4@...wei.com, lilinjie8@...wei.com,
	pangliyuan1@...wei.com, wangkefeng.wang@...wei.com
Subject: Re: [RFC PATCH v2 2/2] ARM/mm/fault: Enable interrupts before
 sending signal

On 2025-11-27 22:01:09 [+0800], Xie Yuanbin wrote:
> --- a/arch/arm/mm/fault.c
> +++ b/arch/arm/mm/fault.c
> @@ -184,10 +184,13 @@ __do_user_fault(unsigned long addr, unsigned int fsr, unsigned int sig,
>  	struct task_struct *tsk = current;
>  
>  	if (addr > TASK_SIZE)
>  		harden_branch_predictor();
>  
> +	if (IS_ENABLED(CONFIG_PREEMPT_RT))
> +		local_irq_enable();

This shouldn't be limited to CONFIG_PREEMPT_RT. There is nothing wrong
with enabling it unconditionally.

>  #ifdef CONFIG_DEBUG_USER
>  	if (((user_debug & UDBG_SEGV) && (sig == SIGSEGV)) ||
>  	    ((user_debug & UDBG_BUS)  && (sig == SIGBUS))) {
>  		pr_err("8<--- cut here ---\n");
>  		pr_err("%s: unhandled page fault (%d) at 0x%08lx, code 0x%03x\n",

Sebastian