linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DEKIG2EXEUS9.28A50WAN06ZMQ@gmail.com>
Date: Fri, 28 Nov 2025 12:40:06 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Krzysztof Kozlowski" <krzk@...nel.org>, "Kurt Borja"
 <kuurtb@...il.com>, "Jonathan Cameron" <jic23@...nel.org>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Tobias Sperling"
 <tobias.sperling@...ting.com>
Cc: "David Lechner" <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, "Andy Shevchenko" <andy@...nel.org>,
 <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Jonathan Cameron"
 <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118

On Fri Nov 28, 2025 at 4:43 AM -05, Krzysztof Kozlowski wrote:
> On 28/11/2025 04:37, Kurt Borja wrote:
>> +
>> +  interrupts:
>> +    description: DOUT/DRDY (Data Out/Data Ready) line.
>> +    maxItems: 1
>> +
>> +  drdy-gpios:
>> +    description:
>> +      Extra GPIO line connected to DOUT/DRDY (Data Out/Data Ready). This allows
>> +      distinguishing between interrupts triggered by the data-ready signal and
>> +      interrupts triggered by an SPI transfer.
>> +    maxItems: 1
>> +
>> +  '#address-cells':
>> +    const: 1
>> +
>> +  '#size-cells':
>> +    const: 0
>
> These two properties are not correct now - you do not have any children.
>
>> +
>> +  '#io-channel-cells':
>> +    const: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - vdd-supply
>> +  - '#address-cells'
>> +  - '#size-cells'
>
> And they should not be required.

I'll drop these. Thank you, Krzysztof!

>
>
> Best regards,
> Krzysztof


-- 
 ~ Kurt