linux-kernel - Re: [PATCH v2] mmc: host: sdhci-msm: Add support for wrapped keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251128175559.GA2000@sol>
Date: Fri, 28 Nov 2025 09:55:59 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Neeraj Soni <neeraj.soni@....qualcomm.com>
Cc: adrian.hunter@...el.com, ulf.hansson@...aro.org, abel.vesa@...aro.org,
	linux-mmc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mmc: host: sdhci-msm: Add support for wrapped keys

On Thu, Nov 27, 2025 at 01:00:48PM +0530, Neeraj Soni wrote:
> Add the wrapped key support for sdhci-msm by implementing the needed
> methods in struct blk_crypto_ll_ops and setting the appropriate flag in
> blk_crypto_profile::key_types_supported.
> 
> ---
> This is a reworked version of the patchset
> https://lore.kernel.org/all/20241101031539.13285-1-quic_spuppala@quicinc.com/
> that was sent by Seshu Madhavi Puppala.
> 
> My changes rebase it to use the custom crypto profile support.
> 
> Signed-off-by: Neeraj Soni <neeraj.soni@....qualcomm.com>

Your Signed-off-by should go above the scissors line (---).

> Changes in v2:
> - Updated commit message for clarity.
> 
> Changes in v1:
> - Added initial support for wrapped keys.
> ---
>  drivers/mmc/host/sdhci-msm.c | 51 +++++++++++++++++++++++++++++++-----
>  1 file changed, 45 insertions(+), 6 deletions(-)

Otherwise the patch looks okay to me.  It lines up with the UFS
equivalent.  Can you also provide details on how you tested it?

- Eric