linux-kernel - Re: [PATCH] virtio_ring: code cleanup in detach_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEs4r6Ovd-HPSLOt4xkTFya16usmQh0ti407bYiQrQnn_A@mail.gmail.com>
Date: Fri, 28 Nov 2025 10:24:34 +0800
From: Jason Wang <jasowang@...hat.com>
To: "zhangdongchuan@...incomputing.com" <zhangdongchuan@...incomputing.com>
Cc: mst <mst@...hat.com>, xuanzhuo <xuanzhuo@...ux.alibaba.com>, 
	eperezma <eperezma@...hat.com>, virtualization <virtualization@...ts.linux.dev>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio_ring: code cleanup in detach_buf_split

On Wed, Nov 26, 2025 at 11:41 AM zhangdongchuan@...incomputing.com
<zhangdongchuan@...incomputing.com> wrote:
>
> Since the return value of vring_unmap_one_split() is exactly
> vq->split.desc_extra[i].next, 'i = vq->split.desc_extra[i].next' is
> redundant. Assign vring_unmap_one_split() to i instead.
>
> Since vq->split.desc_extra is assigned to extra, use extra[i].next
> instead of vq->split.desc_extra[i].next to improve readability.
>
> No change in functionality.
>
> Signed-off-by: zhangdongchuan <zhangdongchuan@...incomputing.com>
> ---

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks