linux-kernel - Re: [PATCH] rust: miscdevice: use `pin_init::zeroed()` for C type initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kmm_6fGRW9y0DXZVEmFoqi-8-YuGJifEcFF7vGQnPLHw@mail.gmail.com>
Date: Fri, 28 Nov 2025 20:08:06 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Atharv Dubey <atharvd440@...il.com>
Cc: arnd@...db.de, gregkh@...uxfoundation.org, ojeda@...nel.org, 
	alex.gaynor@...il.com, boqun.feng@...il.com, gary@...yguo.net, 
	bjorn3_gh@...tonmail.com, lossin@...nel.org, a.hindborg@...nel.org, 
	aliceryhl@...gle.com, tmgross@...ch.edu, dakr@...nel.org, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: miscdevice: use `pin_init::zeroed()` for C type initialization

On Fri, Nov 28, 2025 at 5:23 PM Atharv Dubey <atharvd440@...il.com> wrote:
>
> Replace manual zero-initialization using
> `MaybeUninit::zeroed().assume_init()` with `pin_init::zeroed()`.
> The `pin_init` helper provides a safer and clearer API for
> zero-initializing C structs without requiring an `unsafe` block.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Signed-off-by: Atharv Dubey <atharvd440@...il.com>

Welcome! I am glad you ended up sending a patch :)

Minor procedural nit: I think this is missing:

Suggested-by: Benno Lossin <lossin@...nel.org>

It should be picked up automatically, no need to resend a v2 just for this.

Thanks!

Cheers,
Miguel