linux-kernel - Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62ce91326c0e1d5aef1ad5ecad9b99695f983347@postmarketos.org>
Date: Fri, 28 Nov 2025 20:20:40 +0000
From: "Paul Sajna" <sajattack@...tmarketos.org>
To: "Bjorn Andersson" <andersson@...nel.org>, "Konrad Dybcio"
 <konradybcio@...nel.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "David Heidelberg" <david@...t.cz>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org, "Amir Dahan"
 <system64fumo@...tonmail.com>, "Christopher Brown"
 <crispybrown@...il.com>, "Konrad Dybcio" <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera
 flash

I did more testing on this, and the led only comes on if it's brightness is set to approx 150/255 or lower. In that case, should I set led-max-microamp to 60mA?



November 25, 2025 at 8:12 AM, "Paul Sajna" <sajattack@...tmarketos.org mailto:sajattack@...tmarketos.org?to=%22Paul%20Sajna%22%20%3Csajattack%40postmarketos.org%3E > wrote:


> 
> Camera doesn't work yet (imx351), but we can use the flash as a flashlight.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 93b9a0246510..fa664b5120d2 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -494,6 +494,19 @@ &pm8998_resin {
>  status = "okay";
>  };
>  
> +&pmi8998_flash {
> + status = "okay";
> +
> + led-0 {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + led-sources = <1>;
> + led-max-microamp = <100000>;
> + flash-max-microamp = <500000>;
> + flash-max-timeout-us = <500000>;
> + };
> +};
> +
>  &pmi8998_lpg {
>  status = "okay";
>  
> 
> -- 
> 2.52.0
>