Message-Id: <176429984551.1030074.10716294618988682110.robh@kernel.org>
Date: Thu, 27 Nov 2025 21:17:25 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Chaoyi Chen <kernel@...kyi.com>
Cc: Sandy Huang <hjc@...k-chips.com>, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
 Diederik de Haas <didi.debian@...ow.org>, Dragan Simic <dsimic@...jaro.org>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 linux-phy@...ts.infradead.org, Andy Yan <andy.yan@...k-chips.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Johan Jonker <jbx6244@...il.com>, 
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>, 
 Robert Foss <rfoss@...nel.org>, 
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
 Heiko Stuebner <heiko@...ech.de>, 
 Kishon Vijay Abraham I <kishon@...nel.org>, 
 Neil Armstrong <neil.armstrong@...aro.org>, 
 linux-rockchip@...ts.infradead.org, 
 Jernej Skrabec <jernej.skrabec@...il.com>, 
 Maxime Ripard <mripard@...nel.org>, Jonas Karlman <jonas@...boo.se>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Chaoyi Chen <chaoyi.chen@...k-chips.com>, 
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
 Amit Sunil Dhamne <amitsd@...gle.com>, linux-kernel@...r.kernel.org, 
 dri-devel@...ts.freedesktop.org, Conor Dooley <conor+dt@...nel.org>, 
 Vinod Koul <vkoul@...nel.org>, Peter Chen <hzpeterchen@...il.com>, 
 Luca Ceresoli <luca.ceresoli@...tlin.com>, 
 Peter Robinson <pbrobinson@...il.com>, 
 Yubing Zhang <yubing.zhang@...k-chips.com>, Simona Vetter <simona@...ll.ch>, 
 linux-arm-kernel@...ts.infradead.org, 
 Frank Wang <frank.wang@...k-chips.com>, linux-usb@...r.kernel.org, 
 devicetree@...r.kernel.org, Andrzej Hajda <andrzej.hajda@...el.com>
Subject: Re: [PATCH v11 05/11] dt-bindings: phy: rockchip:
 rk3399-typec-phy: Support mode-switch


On Fri, 28 Nov 2025 10:03:59 +0800, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
> 
> The RK3399 SoC integrates two USB/DP combo PHYs, each of which
> supports software-configurable pin mapping and DisplayPort lane
> assignment. These capabilities enable the PHY itself to handle both
> mode switching and orientation switching, based on the Type-C plug
> orientation and USB PD negotiation results.
> 
> While an external Type-C controller is still required to detect cable
> attachment and report USB PD events, the actual mode and orientation
> switching is performed internally by the PHY through software
> configuration. This allows the PHY to act as a Type-C multiplexer for
> both data role and DP altmode configuration.
> 
> To reflect this hardware design, this patch introduces a new
> "mode-switch" property for the dp-port node in the device tree bindings.
> This property indicates that the connected PHY is capable of handling
> Type-C mode switching itself.
> 
> Signed-off-by: Chaoyi Chen <chaoyi.chen@...k-chips.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> 
> (no changes since v5)
> 
> Changes in v4:
> - Remove "|" in description.
> 
> Changes in v3:
> - Add more descriptions to clarify the role of the PHY in switching.
> 
> Changes in v2:
> - Reuse dp-port/usb3-port in rk3399-typec-phy binding.
> 
>  .../devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml  | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@...80000 (qcom,slim-ngd-v1.5.0): 'audio-codec@1,0' does not match any of the regexes: '^pinctrl-[0-9]+$', '^slim@[0-9a-f]+$'
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@...80000 (qcom,slim-ngd-v1.5.0): #address-cells: 1 was expected
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@...80000 (qcom,slim-ngd-v1.5.0): 'dmas' is a required property
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/slimbus/slimbus.example.dtb: slim@...80000 (qcom,slim-ngd-v1.5.0): 'dma-names' is a required property
	from schema $id: http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...3000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...3000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...5000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...5000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251128020405.90-6-kernel@airkyi.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Powered by blists - more mailing lists