linux-kernel - Re: [PATCH] f2fs: fix to check bio after __blkdev_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25a50204-73c0-4426-8680-f7f87599ac05@kernel.org>
Date: Fri, 28 Nov 2025 11:34:26 +0800
From: Chao Yu <chao@...nel.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: chao@...nel.org, jaegeuk@...nel.org,
 linux-f2fs-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
 stable@...nel.org
Subject: Re: [PATCH] f2fs: fix to check bio after __blkdev_issue_discard()

On 11/26/25 14:41, Christoph Hellwig wrote:
> It can only return blk_alloc_discard_bio if the the gfp_mask doesn't
> allow sleeping (which isn't the case here), or nr_sect is zero,
> which I hope is also not the case as __submit_discard_cmd would
> run into various other problems.  So no, I don't think this is
> patch makes any sense.

Oh, I checked details in bio_alloc_bioset() again, it seems I missed
something for mempool_alloc(), as you mentioned, it may only fail due
to caller is in non-sleep context passing gfp w/ GFP_ATOMIC or
GFP_NOWAIT, which is not the case for f2fs discard.

Thanks,