linux-kernel - Re: [PATCH] fs/fat: Remove unnecessary wrapper fat_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87qztireza.fsf@mail.parknet.co.jp>
Date: Fri, 28 Nov 2025 12:52:09 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Lalit Shankar Chowdhury <lalitshankarch@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/fat: Remove unnecessary wrapper fat_max_cache()

Lalit Shankar Chowdhury <lalitshankarch@...il.com> writes:

> fat_max_cache() always returned FAT_MAX_CACHE and did not use the inode
> parameter. So, use the FAT_MAX_CACHE constant directly.
>
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@...il.com>

Looks good.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> ---
>  fs/fat/cache.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 2af424e200b3..630f3056658e 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -29,11 +29,6 @@ struct fat_cache_id {
>  	int dcluster;
>  };
>  
> -static inline int fat_max_cache(struct inode *inode)
> -{
> -	return FAT_MAX_CACHE;
> -}
> -
>  static struct kmem_cache *fat_cache_cachep;
>  
>  static void init_once(void *foo)
> @@ -145,7 +140,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
>  
>  	cache = fat_cache_merge(inode, new);
>  	if (cache == NULL) {
> -		if (MSDOS_I(inode)->nr_caches < fat_max_cache(inode)) {
> +		if (MSDOS_I(inode)->nr_caches < FAT_MAX_CACHE) {
>  			MSDOS_I(inode)->nr_caches++;
>  			spin_unlock(&MSDOS_I(inode)->cache_lru_lock);

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>