linux-kernel - Re: [PATCH next] btrfs: tests: Fix double free in remove_extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c96af12-cf44-4028-b3c4-4ce9314c4733@gmail.com>
Date: Fri, 28 Nov 2025 12:11:59 +0800
From: Sun Yangkai <sunk67188@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
 linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] btrfs: tests: Fix double free in remove_extent_ref()

Thanks. My bad.

在 2025/11/27 15:14, Dan Carpenter 写道:
> We converted this code to use auto free cleanup.h magic but one old
> school free was accidentally left behind which leads to a double free
> bug.
> 
> Fixes: a320476ca8a3 ("btrfs: tests: do trivial BTRFS_PATH_AUTO_FREE conversions")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  fs/btrfs/tests/qgroup-tests.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/btrfs/tests/qgroup-tests.c b/fs/btrfs/tests/qgroup-tests.c
> index 05cfda8af422..e9124605974b 100644
> --- a/fs/btrfs/tests/qgroup-tests.c
> +++ b/fs/btrfs/tests/qgroup-tests.c
> @@ -187,7 +187,6 @@ static int remove_extent_ref(struct btrfs_root *root, u64 bytenr,
>  	ret = btrfs_search_slot(&trans, root, &key, path, -1, 1);
>  	if (ret) {
>  		test_err("couldn't find backref %d", ret);
> -		btrfs_free_path(path);
>  		return ret;
>  	}
>  	btrfs_del_item(&trans, root, path);