linux-kernel - Re: [PATCH v2] erofs: get rid of raw bi_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSjzua4jp_zZ1g1o@fedora>
Date: Fri, 28 Nov 2025 08:58:33 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc: linux-erofs@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	Stephen Zhang <starzhangzsd@...il.com>
Subject: Re: [PATCH v2] erofs: get rid of raw bi_end_io() usage

On Thu, Nov 27, 2025 at 04:07:56PM +0800, Gao Xiang wrote:
> These BIOs are actually harmless in practice, as they are all pseudo
> BIOs and do not use advanced features like chaining.  Using the BIO
> interface is a more friendly and unified approach for both bdev and
> and file-backed I/Os.
> 
> Let's use bio_endio() instead.
> 
> Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
> ---
> v2:
>  - call bio_endio() unconditionally in erofs_fileio_ki_complete().

bio_endio() can cover bio not submitted yet, so:

Reviewed-by: Ming Lei <ming.lei@...hat.com>


Thanks,
Ming