linux-kernel - Re: [PATCH] MEDIATEK: serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025112812-encounter-breath-8948@gregkh>
Date: Fri, 28 Nov 2025 06:53:04 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "zhiyong.tao" <zhiyong.tao@...iatek.com>
Cc: Jiri Slaby <jirislaby@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Project_Global_Digits_Upstream_Group@...iatek.com,
	liguo.zhang@...iatek.com, Vasanth.Reddy@...iatek.com,
	Yenchia Chen <yenchia.chen@...iatek.com>
Subject: Re: [PATCH] MEDIATEK: serial: 8250_mtk: Add ACPI support

On Fri, Nov 28, 2025 at 10:17:56AM +0800, zhiyong.tao wrote:
> From: "Zhiyong.Tao" <zhiyong.tao@...iatek.com>

Please use your name, not your email alias (i.e. drop the "." from the
name portion.)

> Add ACPI support to 8250_mtk driver. This makes it possible to
> use UART on ARM-based desktops with EDK2 UEFI firmware.
> 
> Signed-off-by: Yenchia Chen <yenchia.chen@...iatek.com>
> Signed-off-by: Zhiyong.Tao <zhiyong.tao@...iatek.com>
> ---
>  drivers/tty/serial/8250/8250_mtk.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index 5875a7b9b4b1..e6a56cf54ae0 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -19,6 +19,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/tty.h>
>  #include <linux/tty_flip.h>
> +#include <linux/units.h>

Do you also need to update the Kconfig dependencies?

thanks,

greg k-h