linux-kernel - [PATCH v4 1/3] mm: pagewalk: simplify hugepage boundary calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35ab82f052d248c0047c10bf01853e37e4f9b4e4.1764312627.git.chandna.sahil@gmail.com>
Date: Fri, 28 Nov 2025 12:31:42 +0530
From: Sahil Chandna <chandna.sahil@...il.com>
To: akpm@...ux-foundation.org,
	david@...hat.com,
	lorenzo.stoakes@...cle.com,
	mhocko@...e.com,
	vbabka@...e.cz,
	rppt@...nel.org,
	surenb@...gle.com,
	hannes@...xchg.org,
	shakeel.butt@...ux.dev,
	zhengqi.arch@...edance.com,
	Liam.Howlett@...cle.com,
	weixugc@...gle.com,
	axelrasmussen@...gle.com,
	yuanchu@...gle.com,
	yosry.ahmed@...ux.dev,
	nphamcs@...il.com,
	chengming.zhou@...ux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Cc: david@...nel.org,
	Sahil Chandna <chandna.sahil@...il.com>,
	Matthew Wilcox <willy@...radead.org>,
	David Laight <david.laight.linux@...il.com>
Subject: [PATCH v4 1/3] mm: pagewalk: simplify hugepage boundary calculation

Replace hugepage boundary computation with ALIGN() helper instead of
an open coded expression. This helps to improves code readability.

This was flagged by Coccinelle (misc/minmax.cocci) as an opportunity
to use min(), after which the boundary computation was updated following
review suggestions.

Found by: make coccicheck MODE=report M=mm/
No functional change intended.

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>
Suggested-by: David Hildenbrand (Red Hat) <david@...nel.org>
Suggested-by: Matthew Wilcox <willy@...radead.org>
Suggested-by: David Laight <david.laight.linux@...il.com>
Signed-off-by: Sahil Chandna <chandna.sahil@...il.com>
---
 mm/pagewalk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index 9f91cf85a5be..9fd59d517f37 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -312,8 +312,7 @@ static int walk_pgd_range(unsigned long addr, unsigned long end,
 static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
 				       unsigned long end)
 {
-	unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
-	return boundary < end ? boundary : end;
+	return min(ALIGN(addr, huge_page_size(h)), end);
 }
 
 static int walk_hugetlb_range(unsigned long addr, unsigned long end,
-- 
2.50.1