linux-kernel - Re: [PATCH] fanotify: Don't call fsnotify_destroy_group() when fsnotify_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251128-umzug-sandgrube-d5b1adfccf02@brauner>
Date: Fri, 28 Nov 2025 09:53:21 +0100
From: Christian Brauner <brauner@...nel.org>
To: Jan Kara <jack@...e.cz>,
	Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: Christian Brauner <brauner@...nel.org>,
	Amir Goldstein <amir73il@...il.com>,
	Matthew Bobrowski <repnop@...gle.com>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzbot+321168dfa622eda99689@...kaller.appspotmail.com
Subject: Re: [PATCH] fanotify: Don't call fsnotify_destroy_group() when fsnotify_alloc_group() fails.

On Thu, 27 Nov 2025 20:16:15 +0000, Kuniyuki Iwashima wrote:
> syzbot reported the splat in __do_sys_fanotify_init(). [0]
> 
> The cited commit introduced the fsnotify_group class.
> 
> The constructor is fsnotify_alloc_group() and could fail,
> so the error is handled this way:
> 
> [...]

Applied to the vfs-6.19.fd_prepare branch of the vfs/vfs.git tree.
Patches in the vfs-6.19.fd_prepare branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.19.fd_prepare

[1/1] fanotify: Don't call fsnotify_destroy_group() when fsnotify_alloc_group() fails.
      https://git.kernel.org/vfs/vfs/c/c2f27f6b8c79