linux-kernel - Re: [PATCH] fs/namespace: fix mntput of ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251128-leitfaden-aufpassen-c0ecf32c1020@brauner>
Date: Fri, 28 Nov 2025 10:26:35 +0100
From: Christian Brauner <brauner@...nel.org>
To: Deepanshu Kartikey <kartikey406@...il.com>
Cc: Christian Brauner <brauner@...nel.org>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzbot+94048264da5715c251f9@...kaller.appspotmail.com,
	viro@...iv.linux.org.uk,
	jack@...e.cz
Subject: Re: [PATCH] fs/namespace: fix mntput of ERR_PTR in fsmount error path

On Fri, 28 Nov 2025 09:21:48 +0530, Deepanshu Kartikey wrote:
> When vfs_create_mount() fails and returns an error pointer, the
> __free(path_put) cleanup attribute causes path_put() to be called
> on the error pointer, which then calls mntput() on an invalid
> pointer value (e.g., -ENOENT = 0xfffffffffffffff4).
> 
> This results in a general protection fault in mntput() when KASAN
> tries to check the shadow memory for the near-null address computed
> from the error pointer offset.
> 
> [...]

Thanks! Heavily rewritten but I retained your authorship.

---

Applied to the vfs-6.19.fd_prepare branch of the vfs/vfs.git tree.
Patches in the vfs-6.19.fd_prepare branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.19.fd_prepare

[1/1] fs/namespace: fix mntput of ERR_PTR in fsmount error path
      https://git.kernel.org/vfs/vfs/c/721ebc9c4a95