linux-kernel - Re: [PATCH] locking/mutex: Initialize mutex::magic even when LOCKDEP=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251128095552.GG3245006@noisy.programming.kicks-ass.net>
Date: Fri, 28 Nov 2025 10:55:52 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Boqun Feng <boqun.feng@...il.com>, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org, akpm@...ux-foundation.org,
	Nathan Chancellor <nathan@...nel.org>,
	Waiman Long <longman@...hat.com>, Ingo Molnar <mingo@...hat.com>,
	Will Deacon <will@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] locking/mutex: Initialize mutex::magic even when
 LOCKDEP=n

On Fri, Nov 28, 2025 at 04:08:15PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 25 Nov 2025 06:54:21 -0800 Boqun Feng <boqun.feng@...il.com> wrote:
> >
> > When DEBUG_MUTEXES=y and LOCKDEP=n, mutex_lock() still checks on
> > ->magic, hence debug_mutex_init() should be called in  
> > mutex_init_generic() as well. While we are at it, decouple LOCKDEP
> > logic from debug_mutex_init(), because in this way debug_mutex_init()
> > only needs one parameter, and we now have mutex_init_lockep() for
> > LOCKDEP=y scenarios.
> > 
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Closes: https://lore.kernel.org/lkml/20251117202214.4f710f02@canb.auug.org.au/
> > Reported-by: Nathan Chancellor <nathan@...nel.org>
> > Closes: https://lore.kernel.org/lkml/20251121215819.GA1374726@ax162/
> > Fixes: 3572e2edc7b6 ("locking/mutex: Redo __mutex_init()")
> > Reviewed-by: Waiman Long <longman@...hat.com>
> > Signed-off-by: Boqun Feng <boqun.feng@...il.com>
> > ---
> > Peter,
> > 
> > Feel free to fold it into commit 3572e2edc7b6 ("locking/mutex: Redo
> > __mutex_init()"), just resend it properly so it won't fall off your
> > radar ;-)
> > 
> >  kernel/locking/mutex-debug.c | 10 +---------
> >  kernel/locking/mutex.c       |  8 +++++++-
> >  kernel/locking/mutex.h       |  5 ++---
> >  3 files changed, 10 insertions(+), 13 deletions(-)
> 
> Any chance if this being applied?  I am still seeing the boot warning.

Should be sorted now, sorry for the delay!