linux-kernel - Re: [PATCH 1/2] mcb: Add missing modpost build support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSl63fQ0HX2ywKIj@MNI-190>
Date: Fri, 28 Nov 2025 11:35:09 +0100
From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Jiri Slaby <jirislaby@...nel.org>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	linus.walleij@...aro.org, brgl@...nel.org, jic23@...nel.org,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	gregkh@...uxfoundation.org, morbidrsa@...il.com, jth@...nel.org,
	wim@...ux-watchdog.org, linux@...ck-us.net, nathan@...nel.org,
	nsc@...nel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-watchdog@...r.kernel.org,
	linux-kbuild@...r.kernel.org,
	Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
Subject: Re: [PATCH 1/2] mcb: Add missing modpost build support

On Fri, Nov 28, 2025 at 11:02:57AM +0200, Andy Shevchenko wrote:
> On Fri, Nov 28, 2025 at 08:54:18AM +0100, Jiri Slaby wrote:
> > On 27. 11. 25, 17:10, Andy Shevchenko wrote:
> 
> ...
> 
> > > >   static const struct devtable devtable[] = {
> > > 
> > > >          {"cpu", SIZE_cpu_feature, do_cpu_entry},
> > > >          {"mei", SIZE_mei_cl_device_id, do_mei_entry},
> > > >          {"rapidio", SIZE_rio_device_id, do_rio_entry},
> > > > +       {"mcb", SIZE_mcb_device_id, do_mcb_entry},
> > > 
> > > Perhaps squeeze it to be more ordered (yes, I know that the table is
> > > not so ordered, but given context suggests to put it after "mei").

Thanks your answers,

I put it between "rapidio" and "ulpi" because mcb_device_id is defined in
mod_devicetable.h between rio_device_id and ulpi_device_id so I though it
could be nice to follow the same order on file2alias.c.

> > 
> > s/after/before/ :)
> 
> Right, good catch!
> 

It is OK to me, I will put it before mei ;)

> -- 
> With Best Regards,
> Andy Shevchenko
> 
>