linux-kernel - Re: [PATCH 0/2] mcb: Add modpost support for processing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSl9bN2Yv5rib_-O@MNI-190>
Date: Fri, 28 Nov 2025 11:46:04 +0100
From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
CC: linus.walleij@...aro.org, brgl@...nel.org, jic23@...nel.org,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	gregkh@...uxfoundation.org, jirislaby@...nel.org,
	morbidrsa@...il.com, jth@...nel.org, wim@...ux-watchdog.org,
	linux@...ck-us.net, nathan@...nel.org, nsc@...nel.org,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-serial@...r.kernel.org,
	linux-watchdog@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH 0/2] mcb: Add modpost support for processing
 MODULE_DEVICE_TABLE

On Thu, Nov 27, 2025 at 06:16:03PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 27, 2025 at 5:56 PM Jose Javier Rodriguez Barbarin
> <dev-josejavier.rodriguez@...gon.com> wrote:
> >
> > During the process of update of one of the device drivers that are part of
> > mcb bus (gpio-menz127.c),
> 
> > one maintainer of the GPIO subsystem
> 
> Krzysztof? Did I miss something and he is now a (co)maintainer here?
> 

I'm sorry, it's my fault, I confused the person who answered me the first time 
with one of the maintainers. Krzysztof and Linus both answered me.

> > asked me
> > why I was adding new MODULE_ALIAS when I also added the same new
> > information on MODULE_DEVICE_TABLE.
> >
> > You can find the messages here:
> >
> > https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@kernel.org/
> >
> > After a deeper analysis, I came across that the mcb_table_id defined inside
> > MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was
> > not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former
> > contributors were using MODULE_ALIAS for enabling mcb to autoload the
> > device drivers.
> >
> > My proposal with these changes is to complete the mcb bus by adding
> > modpost support for processing mcb MODULE_DEVICE_TABLE and removing
> > MODULE_ALIAS from all device drivers as they are no longer needed.
> >
> > Jose Javier Rodriguez Barbarin (2):
> >   mcb: Add missing modpost build support
> >   mcb: Remove MODULE_ALIAS from all mcb client drivers
> >
> >  drivers/gpio/gpio-menz127.c            | 1 -
> >  drivers/iio/adc/men_z188_adc.c         | 1 -
> >  drivers/tty/serial/8250/8250_men_mcb.c | 3 ---
> >  drivers/tty/serial/men_z135_uart.c     | 1 -
> >  drivers/watchdog/menz69_wdt.c          | 1 -
> >  scripts/mod/devicetable-offsets.c      | 3 +++
> >  scripts/mod/file2alias.c               | 9 +++++++++
> >  7 files changed, 12 insertions(+), 7 deletions(-)
> >
> > --
> > 2.51.1
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Thanks for you review, I will send a V2 following your suggestions.

Regards,

Javier Rodriguez.