linux-kernel - Re: [PATCH] platform/x86/intel/hid: Add Dell Pro Rugged 10/12 tablet to VGBS DMI quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6475946d-f3a6-42b6-b88a-be28556e72d2@kernel.org>
Date: Fri, 28 Nov 2025 11:56:21 +0100
From: Hans de Goede <hansg@...nel.org>
To: "Chia-Lin Kao (AceLan)" <acelan.kao@...onical.com>,
 Alex Hung <alexhung@...il.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/intel/hid: Add Dell Pro Rugged 10/12 tablet
 to VGBS DMI quirks

Hi,

On 27-Nov-25 8:04 AM, Chia-Lin Kao (AceLan) wrote:
> Dell Pro Rugged 10/12 tablets has a reliable VGBS method.
> If VGBS is not called on boot, the on-screen keyboard won't appear if the
> device is booted without a keyboard.
> 
> Call VGBS on boot on thess devices to get the initial state of
> SW_TABLET_MODE in a reliable way.
> 
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@...onical.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@....qualcomm.com>

Regards,

Hans



> ---
>  drivers/platform/x86/intel/hid.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 9c07a7faf18f..560cc063198e 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -177,6 +177,18 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "HP Elite Dragonfly G2 Notebook PC"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 10 Tablet RA00260"),
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 12 Tablet RA02260"),
> +		},
> +	},
>  	{ }
>  };
>