linux-kernel - Re: [PATCH] hugetlb: Add guard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251128112307.80237-1-fushuai.wang@linux.dev>
Date: Fri, 28 Nov 2025 19:23:07 +0800
From: Fushuai Wang <fushuai.wang@...ux.dev>
To: david@...nel.org
Cc: fushuai.wang@...ux.dev,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	muchun.song@...ux.dev,
	osalvador@...e.de,
	wangfushuai@...du.com
Subject: Re: [PATCH] hugetlb: Add guard support

>>   include/linux/hugetlb.h | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>> 
>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
>> index 8e63e46b8e1f..f97cb2f123a3 100644
>> --- a/include/linux/hugetlb.h
>> +++ b/include/linux/hugetlb.h
>> @@ -15,6 +15,7 @@
>>   #include <linux/gfp.h>
>>   #include <linux/userfaultfd_k.h>
>>   #include <linux/nodemask.h>
>> +#include <linux/cleanup.h>
>>   
>>   struct ctl_table;
>>   struct user_struct;
>> @@ -468,6 +469,13 @@ static inline void hugetlb_split(struct vm_area_struct *vma, unsigned long addr)
>>   
>>   #endif /* !CONFIG_HUGETLB_PAGE */
>>   
>> +DEFINE_GUARD(hugetlb_vma_read, struct vm_area_struct *,
>> +	     hugetlb_vma_lock_read(_T), hugetlb_vma_unlock_read(_T))
>> +
>> +DEFINE_GUARD(hugetlb_vma_write, struct vm_area_struct *,
>> +	     hugetlb_vma_lock_write(_T), hugetlb_vma_unlock_write(_T))
>> +DEFINE_GUARD_COND(hugetlb_vma_write, _try, hugetlb_vma_trylock_write(_T))
> 
> Do I understand correctly that the code you are introducing does not 
> have any users?

Yes, it is not used now, but it can be used in future development to simplify
the code. If there are complex hugetlb_vma locks in the current code, this can
also be used later to optimize them.

---
Regards,
Wang.