linux-kernel - Re: [rtla 08/13] rtla: Use standard exit codes for result enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAq0SUmsdk=uQ7NcjWHZDetm__q5CPxe+H-U01GefJXASN=6HQ@mail.gmail.com>
Date: Fri, 28 Nov 2025 11:04:23 -0300
From: Wander Lairson Costa <wander@...hat.com>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Tomas Glozar <tglozar@...hat.com>, 
	Ivan Pravdin <ipravdin.official@...il.com>, Crystal Wood <crwood@...hat.com>, 
	John Kacur <jkacur@...hat.com>, Tiezhu Yang <yangtiezhu@...ngson.cn>, 
	"open list:Real-time Linux Analysis (RTLA) tools" <linux-trace-kernel@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>, 
	"open list:BPF [MISC]:Keyword:(?:b|_)bpf(?:b|_)" <bpf@...r.kernel.org>
Subject: Re: [rtla 08/13] rtla: Use standard exit codes for result enum

On Fri, Nov 28, 2025 at 10:18 AM Costa Shulyupin <costa.shul@...hat.com> wrote:
>
> On Mon, 17 Nov 2025 at 20:56, Wander Lairson Costa <wander@...hat.com> wrote:
> >
> >
> > -       PASSED = 0, /* same as EXIT_SUCCESS */
> > -       ERROR = 1,  /* same as EXIT_FAILURE, an error in arguments */
> > -       FAILED = 2, /* test hit the stop tracing condition */
> > +       PASSED  = EXIT_SUCCESS,
> > +       ERROR   = EXIT_FAILURE,
> > +       FAILED, /* test hit the stop tracing condition */
>
> The exit codes are defined as numbers internationally because it provides direct translation from numbers to codes and vice versa. Additional indirection doesn't add to readability.
>

I believe that where it is written "internationally" reads
"intentionally" (happens to me all the time). The main motivation is
to use the standard C library exit codes when calling exit().

> Costa
>
>
> ________________________________
> Hi Wander,
>
> Additional indirection does not add to readability.
>
> Thanks,
> Costa