linux-kernel - Re: [PATCH v2] iio: accel: adxl380: fix handling of unavailable "INT1" interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfRS-6paBqS0oXMq9mVrD5Ms8fX4LRA4k8tK-VV87Lw3Q@mail.gmail.com>
Date: Fri, 28 Nov 2025 17:31:21 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Francesco Lavra <flavra@...libre.com>
Cc: Ramona Gradinariu <ramona.gradinariu@...log.com>, 
	Antoniu Miclaus <antoniu.miclaus@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: accel: adxl380: fix handling of unavailable
 "INT1" interrupt

On Fri, Nov 28, 2025 at 4:07 PM Francesco Lavra <flavra@...libre.com> wrote:
>
> fwnode_irq_get_byname() returns a negative value on failure; if a negative
> value is returned, use it as `err` argument for dev_err_probe().

Reviewed-by: Andy Shevchenko <andy@...nel.org>

...

> +               if (st->irq < 0)
> +                       return dev_err_probe(st->dev, st->irq,
>                                              "no interrupt name specified");

Just noticed that the trailing \n is missing.
Can be also folded or done in a separate patch. Up to you.

-- 
With Best Regards,
Andy Shevchenko