linux-kernel - Re: [PATCH v3] mm/memory hotplug/unplug: Optimize zone->contiguous update when move pfn range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <123e0d99-ef29-4906-828a-9dfd29dafd29@kernel.org>
Date: Fri, 28 Nov 2025 17:04:49 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: "Li, Tianyou" <tianyou.li@...el.com>, Oscar Salvador <osalvador@...e.de>,
 Mike Rapoport <rppt@...nel.org>, Wei Yang <richard.weiyang@...il.com>
Cc: linux-mm@...ck.org, Yong Hu <yong.hu@...el.com>,
 Nanhai Zou <nanhai.zou@...el.com>, Yuan Liu <yuan1.liu@...el.com>,
 Tim Chen <tim.c.chen@...ux.intel.com>, Qiuxu Zhuo <qiuxu.zhuo@...el.com>,
 Yu C Chen <yu.c.chen@...el.com>, Pan Deng <pan.deng@...el.com>,
 Chen Zhang <zhangchen.kidd@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mm/memory hotplug/unplug: Optimize zone->contiguous
 update when move pfn range

> 
> Instead of a bool value, could the clear_zone_contiguous_for_growing
> and clear_zone_contiguous_for_shrinking return a enum value to indicate
> one of the three states: 1. DEFINITELY_CONTIGUOUS;
> 2. DEFINITELY_NOT_CONTIGUOUS; 3. UNDETERMINED_CONTIGUOUS? The
> set_zone_contiguous took the state and skip the contiguous check if
> DEFINITELY_CONTIGUOUS or DEFINITELY_NOT_CONTIGUOUS.

I had the exact same thought while writing my rely, so it's worth 
investigating.

If that helps to come up with even better+descriptive variable/function 
names, even better :)

-- 
Cheers

David