lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251128-vfs-inode-v619-730a38ce04b0@brauner>
Date: Fri, 28 Nov 2025 17:48:14 +0100
From: Christian Brauner <brauner@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Christian Brauner <brauner@...nel.org>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [GIT PULL 03/17 for v6.19] vfs inode

Hey Linus,

/* Summary */
This contains inode specific changes for this cycle:

Features

- Hide inode->i_state behind accessors. Open-coded accesses prevent
  asserting they are done correctly. One obvious aspect is locking, but
  significantly more can be checked. For example it can be detected when
  the code is clearing flags which are already missing, or is setting
  flags when it is illegal (e.g., I_FREEING when ->i_count > 0).

- Provide accessors for ->i_state, converts all filesystems using coccinelle
  and manual conversions (btrfs, ceph, smb, f2fs, gfs2, overlayfs, nilfs2,
  xfs), and makes plain ->i_state access fail to compile.

- Rework I_NEW handling to operate without fences, simplifying the code
  after the accessor infrastructure is in place.

Cleanups

- Move wait_on_inode() from writeback.h to fs.h.

- Spell out fenced ->i_state accesses with explicit smp_wmb/smp_rmb
  for clarity.

- Cosmetic fixes to LRU handling.

- Push list presence check into inode_io_list_del().

- Touch up predicts in __d_lookup_rcu().

- ocfs2: retire ocfs2_drop_inode() and I_WILL_FREE usage.

- Assert on ->i_count in iput_final().

- Assert ->i_lock held in __iget().

Fixes

- Add missing fences to I_NEW handling.

/* Testing */

gcc (Debian 14.2.0-19) 14.2.0
Debian clang version 19.1.7 (3+b1)

No build failures or warnings were observed.

/* Conflicts */

Merge conflicts with mainline
=============================

No known conflicts.

Merge conflicts with other trees
================================

The following changes since commit 3a8660878839faadb4f1a6dd72c3179c1df56787:

  Linux 6.18-rc1 (2025-10-12 13:42:36 -0700)

are available in the Git repository at:

  git@...olite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/vfs-6.19-rc1.inode

for you to fetch changes up to ca0d620b0afae20a7bcd5182606eba6860b2dbf2:

  dcache: touch up predicts in __d_lookup_rcu() (2025-11-28 10:31:45 +0100)

Please consider pulling these changes from the signed vfs-6.19-rc1.inode tag.

Thanks!
Christian

----------------------------------------------------------------
vfs-6.19-rc1.inode

----------------------------------------------------------------
Christian Brauner (1):
      Merge patch series "hide ->i_state behind accessors"

Mateusz Guzik (22):
      fs: assert ->i_lock held in __iget()
      fs: assert on ->i_count in iput_final()
      ocfs2: retire ocfs2_drop_inode() and I_WILL_FREE usage
      fs: add missing fences to I_NEW handling
      fs: move wait_on_inode() from writeback.h to fs.h
      fs: spell out fenced ->i_state accesses with explicit smp_wmb/smp_rmb
      fs: provide accessors for ->i_state
      Coccinelle-based conversion to use ->i_state accessors
      Manual conversion to use ->i_state accessors of all places not covered by coccinelle
      btrfs: use the new ->i_state accessors
      ceph: use the new ->i_state accessors
      smb: use the new ->i_state accessors
      f2fs: use the new ->i_state accessors
      gfs2: use the new ->i_state accessors
      overlayfs: use the new ->i_state accessors
      nilfs2: use the new ->i_state accessors
      xfs: use the new ->i_state accessors
      fs: make plain ->i_state access fail to compile
      fs: rework I_NEW handling to operate without fences
      fs: cosmetic fixes to lru handling
      fs: push list presence check into inode_io_list_del()
      dcache: touch up predicts in __d_lookup_rcu()

 Documentation/filesystems/porting.rst |   2 +-
 block/bdev.c                          |   4 +-
 drivers/dax/super.c                   |   2 +-
 fs/9p/vfs_inode.c                     |   2 +-
 fs/9p/vfs_inode_dotl.c                |   2 +-
 fs/affs/inode.c                       |   2 +-
 fs/afs/dir.c                          |   4 +-
 fs/afs/dynroot.c                      |   6 +-
 fs/afs/inode.c                        |   8 +-
 fs/befs/linuxvfs.c                    |   2 +-
 fs/bfs/inode.c                        |   2 +-
 fs/btrfs/inode.c                      |  10 +-
 fs/buffer.c                           |   4 +-
 fs/ceph/cache.c                       |   2 +-
 fs/ceph/crypto.c                      |   4 +-
 fs/ceph/file.c                        |   4 +-
 fs/ceph/inode.c                       |  28 ++--
 fs/coda/cnode.c                       |   4 +-
 fs/cramfs/inode.c                     |   2 +-
 fs/crypto/keyring.c                   |   2 +-
 fs/crypto/keysetup.c                  |   2 +-
 fs/dcache.c                           |  29 ++--
 fs/drop_caches.c                      |   2 +-
 fs/ecryptfs/inode.c                   |   6 +-
 fs/efs/inode.c                        |   2 +-
 fs/erofs/inode.c                      |   2 +-
 fs/ext2/inode.c                       |   2 +-
 fs/ext4/inode.c                       |  13 +-
 fs/ext4/orphan.c                      |   4 +-
 fs/f2fs/data.c                        |   2 +-
 fs/f2fs/inode.c                       |   2 +-
 fs/f2fs/namei.c                       |   4 +-
 fs/f2fs/super.c                       |   2 +-
 fs/freevxfs/vxfs_inode.c              |   2 +-
 fs/fs-writeback.c                     | 132 +++++++++---------
 fs/fuse/inode.c                       |   4 +-
 fs/gfs2/file.c                        |   2 +-
 fs/gfs2/glock.c                       |   2 +-
 fs/gfs2/glops.c                       |   2 +-
 fs/gfs2/inode.c                       |   4 +-
 fs/gfs2/ops_fstype.c                  |   2 +-
 fs/hfs/btree.c                        |   2 +-
 fs/hfs/inode.c                        |   2 +-
 fs/hfsplus/super.c                    |   2 +-
 fs/hostfs/hostfs_kern.c               |   2 +-
 fs/hpfs/dir.c                         |   2 +-
 fs/hpfs/inode.c                       |   2 +-
 fs/inode.c                            | 247 +++++++++++++++++++---------------
 fs/isofs/inode.c                      |   2 +-
 fs/jffs2/fs.c                         |   4 +-
 fs/jfs/file.c                         |   4 +-
 fs/jfs/inode.c                        |   2 +-
 fs/jfs/jfs_txnmgr.c                   |   2 +-
 fs/kernfs/inode.c                     |   2 +-
 fs/libfs.c                            |   6 +-
 fs/minix/inode.c                      |   2 +-
 fs/namei.c                            |   8 +-
 fs/netfs/misc.c                       |   8 +-
 fs/netfs/read_single.c                |   6 +-
 fs/nfs/inode.c                        |   2 +-
 fs/nfs/pnfs.c                         |   2 +-
 fs/nfsd/vfs.c                         |   2 +-
 fs/nilfs2/cpfile.c                    |   2 +-
 fs/nilfs2/dat.c                       |   2 +-
 fs/nilfs2/ifile.c                     |   2 +-
 fs/nilfs2/inode.c                     |  10 +-
 fs/nilfs2/sufile.c                    |   2 +-
 fs/notify/fsnotify.c                  |   2 +-
 fs/ntfs3/inode.c                      |   2 +-
 fs/ocfs2/dlmglue.c                    |   2 +-
 fs/ocfs2/inode.c                      |  27 +---
 fs/ocfs2/inode.h                      |   1 -
 fs/ocfs2/ocfs2_trace.h                |   2 -
 fs/ocfs2/super.c                      |   2 +-
 fs/omfs/inode.c                       |   2 +-
 fs/openpromfs/inode.c                 |   2 +-
 fs/orangefs/inode.c                   |   2 +-
 fs/orangefs/orangefs-utils.c          |   6 +-
 fs/overlayfs/dir.c                    |   2 +-
 fs/overlayfs/inode.c                  |   6 +-
 fs/overlayfs/util.c                   |  10 +-
 fs/pipe.c                             |   2 +-
 fs/qnx4/inode.c                       |   2 +-
 fs/qnx6/inode.c                       |   2 +-
 fs/quota/dquot.c                      |   2 +-
 fs/romfs/super.c                      |   2 +-
 fs/smb/client/cifsfs.c                |   2 +-
 fs/smb/client/inode.c                 |  14 +-
 fs/squashfs/inode.c                   |   2 +-
 fs/sync.c                             |   2 +-
 fs/ubifs/file.c                       |   2 +-
 fs/ubifs/super.c                      |   2 +-
 fs/udf/inode.c                        |   2 +-
 fs/ufs/inode.c                        |   2 +-
 fs/xfs/scrub/common.c                 |   2 +-
 fs/xfs/scrub/inode_repair.c           |   2 +-
 fs/xfs/scrub/parent.c                 |   2 +-
 fs/xfs/xfs_bmap_util.c                |   2 +-
 fs/xfs/xfs_health.c                   |   4 +-
 fs/xfs/xfs_icache.c                   |   6 +-
 fs/xfs/xfs_inode.c                    |   6 +-
 fs/xfs/xfs_inode_item.c               |   4 +-
 fs/xfs/xfs_iops.c                     |   2 +-
 fs/xfs/xfs_reflink.h                  |   2 +-
 fs/zonefs/super.c                     |   4 +-
 include/linux/backing-dev.h           |   5 +-
 include/linux/fs.h                    |  99 ++++++++++++--
 include/linux/writeback.h             |   9 +-
 include/trace/events/writeback.h      |   8 +-
 mm/backing-dev.c                      |   2 +-
 mm/filemap.c                          |   4 +-
 mm/truncate.c                         |   6 +-
 mm/vmscan.c                           |   2 +-
 mm/workingset.c                       |   2 +-
 security/landlock/fs.c                |   2 +-
 115 files changed, 514 insertions(+), 414 deletions(-)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ