linux-kernel - Re: [PATCH] ipv4: Fix log message for martian source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251127181743.2bdf214b@kernel.org>
Date: Thu, 27 Nov 2025 18:17:43 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Clara Engler <cve@....cx>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org
Subject: Re: [PATCH] ipv4: Fix log message for martian source

On Wed, 26 Nov 2025 22:59:58 +0100 Clara Engler wrote:
> @@ -1796,7 +1796,7 @@ static void ip_handle_martian_source(struct net_device *dev,
>  		 *	the only hint is MAC header.
>  		 */
>  		pr_warn("martian source %pI4 from %pI4, on dev %s\n",
> -			&daddr, &saddr, dev->name);
> +			&saddr, &daddr, dev->name);

imagine there was another comma in this print:

	martian source, %pI4 from %pI4, on dev %s

we should leave it as is, I think.
People may be grepping logs for this exact format..
-- 
pw-bot: reject