linux-kernel - Re: [PATCH v4] MIPS: mm: kmalloc tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2511281654350.36486@angie.orcam.me.uk>
Date: Fri, 28 Nov 2025 16:56:34 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Gregory CLEMENT <gregory.clement@...tlin.com>
cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    Jiaxun Yang <jiaxun.yang@...goat.com>, linux-mips@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] MIPS: mm: kmalloc tlb_vpn array to avoid stack
 overflow

On Fri, 28 Nov 2025, Gregory CLEMENT wrote:

> > Owing to Config4.MMUSizeExt and VTLB/FTLB MMU features later MIPSr2+ 
> > cores can have more than 64 TLB entries.  Therefore allocate an array 
> > for uniquification instead of placing too small an array on the stack.
> >
> > Fixes: 35ad7e181541 ("MIPS: mm: tlb-r4k: Uniquify TLB entries on init")
> > Co-developed-by: Maciej W. Rozycki <macro@...am.me.uk>
> > Signed-off-by: Maciej W. Rozycki <macro@...am.me.uk>
> > Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > Cc: stable@...r.kernel.org # v6.17+: 9f048fa48740: MIPS: mm: Prevent a TLB shutdown on initial uniquification
> > Cc: stable@...r.kernel.org # v6.17+
> 
> Thanks for this patch. It allows booting on EyQ5 and EyeQ6H. However,
> during the build process, I saw this new warning:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: r4k_tlb_configure+0x3e4 (section: .text) -> memblock_alloc_try_nid_raw (section: .init.text)

 Thank you for verification and the report.  I've now posted v5 that fixes 
the issue with `modpost', which was missed in the flood of messages.

  Maciej