linux-kernel - Re: [PATCH] platform/x86: asus-wmi: use brightness_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSqtsuyIDtGrXLrx@smile.fi.intel.com>
Date: Sat, 29 Nov 2025 10:24:18 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Anton Khirnov <anton@...rnov.net>
Cc: Corentin Chary <corentin.chary@...il.com>,
	"Luke D. Jones" <luke@...nes.dev>,
	Denis Benato <benato.denis96@...il.com>,
	Hans de Goede <hansg@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Jian-Hong Pan <jian-hong@...lessm.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: use brightness_set_blocking()
 for kbd led

On Sat, Nov 29, 2025 at 05:02:46AM +0100, Anton Khirnov wrote:
> kbd_led_set() can sleep, and so may not be used as the brightness_set()
> callback.

> Fixes "BUG: scheduling while atomic" when using this led with a trigger.

It might be a bit confusing with (misspelled) Fixes tag, also it would be
better to provide a few (usually ~3-5) lines of the actual traceback.

...

> -static void kbd_led_set(struct led_classdev *led_cdev,
> -			enum led_brightness value)
> +static int kbd_led_set(struct led_classdev *led_cdev,
> +		       enum led_brightness value)

Now it's exactly 80 characters if located on a single line.

-- 
With Best Regards,
Andy Shevchenko