linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58e62b16-2056-470f-a868-1b958949c411@ixit.cz>
Date: Sat, 29 Nov 2025 13:08:32 +0100
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: longnoserob@...il.com, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, phone-devel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable
 SLPI

On 29/11/2025 02:15, Dmitry Baryshkov wrote:
> On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
>> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
>>> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
>>>> From: Robert Eckelmann <longnoserob@...il.com>
>>>>
>>>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
>>>>
>>>> Signed-off-by: Robert Eckelmann <longnoserob@...il.com>
>>>> Signed-off-by: David Heidelberg <david@...t.cz>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>>>>    1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> index 785006a15e97..0fb1d7e724c4 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> @@ -425,6 +425,12 @@ &sdhc_2 {
>>>>    	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>>>>    };
>>>> +&slpi_pas {
>>>> +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
>>>
>>> qcom/sdm845/Xiaomi/beryllium/slpi.mbn
>>
>> Could be this change done for all the firmware files at once but later?
>>
>> Currently all the firmwares using this legacy path.
> 
> I'd rather see the patch fixing firmware paths first and then the patch
> adding SLPI with the correct path from the day 0 (I feel sorry for
> causing pain to PmOS maintainers). Of course both patches can come as a
> part of the same series.

Would it make sense as a follow up, I would changed "the whole sdm845" 
to the new paths, so distros maintainers can update paths everywhere 
with 6.19?

David

> 
>>
>> David
>>
>> [...]
> 

-- 
David Heidelberg