linux-kernel - Re: [PATCH] mtd: lpddr_cmds: fix signed shifts in lpddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176442068453.77093.14391627489442582650.b4-ty@bootlin.com>
Date: Sat, 29 Nov 2025 13:51:24 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Ivan Stepchenko <sid@....spb.ru>
Cc: Richard Weinberger <richard@....at>, 
 Vignesh Raghavendra <vigneshr@...com>, 
 David Woodhouse <David.Woodhouse@...el.com>, 
 Jared Hulbert <jaredeh@...il.com>, Alexey Korolev <akorolev@...radead.org>, 
 linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 lvc-project@...uxtesting.com
Subject: Re: [PATCH] mtd: lpddr_cmds: fix signed shifts in lpddr_cmds

On Fri, 21 Nov 2025 14:54:46 +0300, Ivan Stepchenko wrote:
> There are several places where a value of type 'int' is shifted by
> lpddr->chipshift. lpddr->chipshift is derived from QINFO geometry and
> might reach 31 when QINFO reports a 2 GiB size - the maximum supported by
> LPDDR(1) compliant chips. This may cause unexpected sign-extensions when
> casting the integer value to the type of 'unsigned long'.
> 
> Use '1UL << lpddr->chipshift' and cast 'j' to unsigned long before
> shifting so the computation is performed at the destination width.
> 
> [...]

Applied to mtd/next, thanks!

[1/1] mtd: lpddr_cmds: fix signed shifts in lpddr_cmds
      commit: c909fec69f84b39e63876c69b9df2c178c6b76ba

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl