linux-kernel - Re: [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSr1TIpl2IYtpypS@smile.fi.intel.com>
Date: Sat, 29 Nov 2025 15:29:48 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shenghao Ding <shenghao-ding@...com>
Cc: tiwai@...e.de, broonie@...nel.org, linux-kernel@...r.kernel.org,
	baojun.xu@...com, Baojun.Xu@....com, 13564923607@....com,
	13916275206@....com
Subject: Re: [PATCH v1] ALSA: hda/tas2781: remove an extra space in the
 comment

On Sat, Nov 29, 2025 at 09:51:28AM +0800, Shenghao Ding wrote:
> An extra space in the comment was reported by one of my customers.
> Their careful code review is greatly appreciated.

> Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib")

Definitely not a fix that anyhow needs to be backported or even thought about.

...

>  			/*
>  			 * Our variable names are ASCII by construction, but
> -			 * EFI names are wide chars.  Convert and zero-pad.
> +			 * EFI names are wide chars. Convert and zero-pad.
>  			 */

It's not a problem. This was (still is?) standard way of the spacing in
the (antique :-) computer text in English.

https://www.reddit.com/r/grammar/comments/zn0jxz/two_spaces_after_a_period/

With all that said, no need for this change, it does nothing good or bad, just
unneeded churn.

-- 
With Best Regards,
Andy Shevchenko