linux-kernel - Re: [PATCH 3/4] block: add IOC_PR_READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89bdc184-363c-4d14-bad6-dd4ab65b80d9@kernel.org>
Date: Sat, 29 Nov 2025 15:32:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hannes Reinecke <hare@...e.de>, Stefan Hajnoczi <stefanha@...hat.com>,
 linux-block@...r.kernel.org
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
 linux-kernel@...r.kernel.org,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 Mike Christie <michael.christie@...cle.com>, Jens Axboe <axboe@...nel.dk>,
 linux-nvme@...ts.infradead.org, Keith Busch <kbusch@...nel.org>,
 Sagi Grimberg <sagi@...mberg.me>, linux-scsi@...r.kernel.org,
 Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 3/4] block: add IOC_PR_READ_KEYS ioctl

On 27/11/2025 08:07, Hannes Reinecke wrote:
> 
>> +	size_t keys_info_len = struct_size(keys_info, keys, inout.num_keys);
>> +
>> +	keys_info = kzalloc(keys_info_len, GFP_KERNEL);
>> +	if (!keys_info)
>> +		return -ENOMEM;
>> +
>> +	keys_info->num_keys = inout.num_keys;
>> +
>> +	ret = ops->pr_read_keys(bdev, keys_info);
>> +	if (ret)
>> +		return ret;
>> +
>> +	/* Copy out individual keys */
>> +	u64 __user *keys_ptr = u64_to_user_ptr(inout.keys_ptr);
>> +	u32 num_copy_keys = min(inout.num_keys, keys_info->num_keys);
>> +	size_t keys_copy_len = num_copy_keys * sizeof(keys_info->keys[0]);
> 
> We just had the discussion about variable declarations on the ksummit 
> lists; I really would prefer to have all declarations at the start of 
> the scope (read: at the start of the function here).

Then also cleanup.h should not be used here.

Best regards,
Krzysztof