linux-kernel - Re: [BUG] hwmon: Widespread TOCTOU vulnerabilities in the hwmon subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSsGcLCaXxQChDA8@black.igk.intel.com>
Date: Sat, 29 Nov 2025 15:42:56 +0100
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Gui-Dong Han <hanguidong02@...il.com>, vt8231@...denengine.co.uk,
	steve.glendinning@...well.net, jdelvare@...e.com,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG] hwmon: Widespread TOCTOU vulnerabilities in the hwmon
 subsystem

On Thu, Jun 05, 2025 at 07:33:22AM -0700, Guenter Roeck wrote:
> On Thu, Jun 05, 2025 at 07:49:37PM +0800, Gui-Dong Han wrote:

...

> Also, it might make sense to add a note to
> Documentation/hwmon/submitting-patches.rst, to "avoid calculations in
> macros", explaining that this may result in the kind of problem explained
> here.

No, it might not. Do not blame a messenger (calculations), the problem is
accessing data several times. That one makes sense to add.

-- 
With Best Regards,
Andy Shevchenko