linux-kernel - Re: [PATCH next] mux: mmio: Fix IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a4d8f52-f03d-4498-a488-813b0d0b2d24@kernel.org>
Date: Sat, 29 Nov 2025 16:02:34 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Peter Rosin <peda@...ntia.se>, Andrew Davis <afd@...com>,
 Thorsten Blum <thorsten.blum@...ux.dev>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, Thomas Richard <thomas.richard@...tlin.com>
Subject: Re: [PATCH next] mux: mmio: Fix IS_ERR() vs NULL check in probe()

On 29/11/2025 15:50, Dan Carpenter wrote:
> The devm_kmalloc() function never returns error pointers, it returns
> NULL on error.  Fix the error checking.
> 
> Fixes: 4863cb2b0f50 ("mux: mmio: Add suspend and resume support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/mux/mmio.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
> index e4ddb1e61923..3409af1ffb80 100644
> --- a/drivers/mux/mmio.c
> +++ b/drivers/mux/mmio.c
> @@ -101,13 +101,13 @@ static int mux_mmio_probe(struct platform_device *pdev)
>  	mux_mmio = mux_chip_priv(mux_chip);
>  
>  	mux_mmio->fields = devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->fields), GFP_KERNEL);
> -	if (IS_ERR(mux_mmio->fields))
> -		return PTR_ERR(mux_mmio->fields);
> +	if (!mux_mmio->fields)
> +		return -ENOMEM;
>  

I wonder from where Thomas copied this code...

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

@Greg, that's a fix for something in your tree.

Best regards,
Krzysztof