linux-kernel - Re: [PATCH] docs: submitting-patches: Clarify that removal of Acks needs explanation too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874iqcrh3b.fsf@trenco.lwn.net>
Date: Sat, 29 Nov 2025 08:31:04 -0700
From: Jonathan Corbet <corbet@....net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
 workflows@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Subject: Re: [PATCH] docs: submitting-patches: Clarify that removal of Acks
 needs explanation too

Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com> writes:

> The paragraph mentions only removal of Tested-by and Reviewed-by tags as
> action needing mentioning in patch changelog, so some developers treat
> it too literally.  Acks, as a weaker form of review/approval, should
> rarely be removed, but if that happens it should be explained as well.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> ---
>  Documentation/process/submitting-patches.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 910e8fc9e3c8..9a509f1a6873 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -592,8 +592,9 @@ Both Tested-by and Reviewed-by tags, once received on mailing list from tester
>  or reviewer, should be added by author to the applicable patches when sending
>  next versions.  However if the patch has changed substantially in following
>  version, these tags might not be applicable anymore and thus should be removed.
> -Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
> -in the patch changelog (after the '---' separator).
> +Usually removal of someone's Acked-by, Tested-by or Reviewed-by tags should be
> +mentioned in the patch changelog with an explanation (after the '---'
> +separator).

Applied, thanks.

jon