linux-kernel - Re: [PATCH v2 1/1] docs: makefile: move rustdoc check to the build wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sedwq1sx.fsf@trenco.lwn.net>
Date: Sat, 29 Nov 2025 08:46:38 -0700
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Linux Doc Mailing
 List <linux-doc@...r.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Alex Gaynor
 <alex.gaynor@...il.com>, Alice Ryhl <aliceryhl@...gle.com>, Andreas
 Hindborg <a.hindborg@...nel.org>, Benno Lossin <lossin@...nel.org>,
 Björn
 Roy Baron <bjorn3_gh@...tonmail.com>, Boqun Feng <boqun.feng@...il.com>,
 Carlos Bilbao <carlos.bilbao@...nel.org>, Danilo Krummrich
 <dakr@...nel.org>, Gary Guo <gary@...yguo.net>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Miguel Ojeda <ojeda@...nel.org>, Trevor Gross <tmgross@...ch.edu>,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2 1/1] docs: makefile: move rustdoc check to the build
 wrapper

Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:

> The makefile logic to detect if rust is enabled is not working
> the way it was expected: instead of using the current setup
> for CONFIG_RUST, it uses a cached version from a previous build.
>
> The root cause is that the current logic inside docs/Makefile
> uses a cached version of CONFIG_RUST, from the last time a non
> documentation target was executed. That's perfectly fine for
> Sphinx build, as it doesn't need to read or depend on any
> CONFIG_*.
>
> So, instead of relying at the cache, move the logic to the
> wrapper script and let it check the current content of .config,
> to verify if CONFIG_RUST was selected.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  Documentation/Makefile          |  6 -----
>  tools/docs/sphinx-build-wrapper | 41 +++++++++++++++++++++++++--------
>  2 files changed, 32 insertions(+), 15 deletions(-)

Applied, thanks.

jon