linux-kernel - [PATCH] smb: client: Remove incorrect TODO in cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251129182623.530415-1-aadityakansal390@gmail.com>
Date: Sat, 29 Nov 2025 23:56:23 +0530
From: Aaditya Kansal <aadityakansal390@...il.com>
To: sfrench@...ba.org,
	pc@...guebit.org
Cc: ronniesahlberg@...il.com,
	sprasad@...rosoft.com,
	tom@...pey.com,
	linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	bharathsm@...rosoft.com,
	skhan@...uxfoundation.org,
	david.hunter.linux@...il.com,
	Aaditya Kansal <aadityakansal390@...il.com>
Subject: [PATCH] smb: client: Remove incorrect TODO in cifs_mkdir()

Remove a TODO comment which suggested skipping the call to
cifs_mkdir_qinfo() for SMB 2/3. This is incorrect because
cifs_mkdir_qinfo() contains SMB 2/3 related code.

Signed-off-by: Aaditya Kansal <aadityakansal390@...il.com>
---
 fs/smb/client/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c
index cac355364e43..20acbe88f1c3 100644
--- a/fs/smb/client/inode.c
+++ b/fs/smb/client/inode.c
@@ -2314,7 +2314,6 @@ struct dentry *cifs_mkdir(struct mnt_idmap *idmap, struct inode *inode,
 		goto mkdir_out;
 	}
 
-	/* TODO: skip this for smb2/smb3 */
 	rc = cifs_mkdir_qinfo(inode, direntry, mode, full_path, cifs_sb, tcon,
 			      xid);
 mkdir_out:
-- 
2.52.0