linux-kernel - Re: [PATCH] accel: goya: replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d67ec3a-54dc-4e26-ac5c-480b72a00399@intel.com>
Date: Sat, 29 Nov 2025 22:35:16 +0200
From: "Sinyuk, Konstantin" <konstantin.sinyuk@...el.com>
To: Shi Hao <i.shihao.999@...il.com>, <koby.elbaz@...el.com>
CC: <ogabbay@...nel.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] accel: goya: replace sprintf() with sysfs_emit()

On 10/30/2025 8:35 PM, Shi Hao wrote:
> Replace deprecated sprintf() with sysfs_emit() in various sysfs show
> functions to avoid buffer overflows.
> 
> The sysfs_emit() function is specifically designed for sysfs show handlers
> and provides built-in bounds checking by limiting output to PAGE_SIZE,
> unlike sprintf() which has no bounds checking. This prevents buffer
> overflows that could result in kernel crashes or potential security
> vulnerabilities.
> 
> Convert sprintf() to sysfs_emit() as per kernel code practices and
> guidelines.
> 
> Signed-off-by: Shi Hao <i.shihao.999@...il.com>

Applied to accel/habanalabs-next, thanks.