linux-kernel - Re: [PATCH v6 0/7] Add AMD ISP4 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL3XFnZ3XatQkR2HXpyfT6BK7bCjjGcaS5LjtK0DxPfHX0Q-dg@mail.gmail.com>
Date: Fri, 28 Nov 2025 21:12:44 -0600
From: Sashank Karri <sashank.karri@...il.com>
To: bin.du@....com
Cc: Dominic.Antony@....com, Phil.Jawich@....com, anson.tsao@....com, 
	benjamin.chan@....com, bryan.odonoghue@...aro.org, 
	gjorgji.rosikopulos@....com, hverkuil@...all.nl, king.li@....com, 
	laurent.pinchart+renesas@...asonboard.com, linux-kernel@...r.kernel.org, 
	linux-media@...r.kernel.org, mario.limonciello@....com, mchehab@...nel.org, 
	prabhakar.mahadev-lad.rj@...renesas.com, pratap.nirujogi@....com, 
	richard.gong@....com, sakari.ailus@...ux.intel.com, sultan@...neltoast.com
Subject: Re: [PATCH v6 0/7] Add AMD ISP4 driver

Dear Bin,

I apologize if this is the wrong place to ask this question and
suggest this very slight edit if I understand how ISP4 on the Ryzen AI
Max+ 300 series SoCs works.  So the ASUS Rog Flow Z13 2025 also uses
the same Strix Halo chips, albeit using the non-PRO series.  On the
Windows side, the 13MP sensor, also from Omnivision, requires an AMD
Camera Driver, something speciifcally also required by the  5.2 MP
camera on the HP ZBook Ultra G1a.  So if both MIPI-capable cameras use
the ISP4 technology on the Strix Halo SoC (do they?), this Linux ISP4
driver should apply to both cameras, right? If so, shouldn't the ACPI
ID for the 13MP sensor also be hardcoded into this code

> drm/amd/amdgpu: Declare isp firmware binary file (https://gitlab.freedesktop.org/agd5f/linux/-/commit/35345917bc9f7c86152b270d9d93c220230b667f)

Adam J. Sypniewski suggested hardcoding the ACPI ID into the I2C
driver here to have the 13MP camera to work (the ASUS specific ACPI ID
for the sensor can be found here):
https://lore.kernel.org/lkml/aPeqy11m-TxwbzJV@garrus/

I'm entirely new to the Linux kernel mailing list and very unfamiliar
with webcam interfaces and how ASUS has chosen to interface the 13 MP
sensor with the system, but I can confirm that it does not work yet in
the Linux desktop, so I was wondering if the work on this new driver
is necessary to get it to work.

Sashank