linux-kernel - Re: [PATCH v2 04/13] tools/nolibc/time: drop invocation of gettimeofday system call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251130104221.GC31522@1wt.eu>
Date: Sun, 30 Nov 2025 11:42:21 +0100
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Shuah Khan <shuah@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 04/13] tools/nolibc/time: drop invocation of
 gettimeofday system call

On Sat, Nov 22, 2025 at 05:59:10PM +0100, Thomas Weißschuh wrote:
> This invocation uses libc types with a system call. While this works
> now, upcoming changes to 'struct timeval' would require type
> conversions. If types are converted anyways, the clock_gettime() based
> fallback can be used everywhere, simplifying the code.

I must confess I'm not happy to see the simple, lightweight and efficient
gettimeofday() quit, with the alternative being a bit bigger, but after
enough testing, aside the code size increase I cannot spot any problem.

> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Acked-by: Willy Tarreau <w@....eu>

Willy