linux-kernel - Re: [PATCH net-next 3/3] net: enetc: convert to use .get_rx_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSxhG-WcSMv9DbLn@horms.kernel.org>
Date: Sun, 30 Nov 2025 15:22:03 +0000
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Claudiu Manoil <claudiu.manoil@....com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Ioana Ciornei <ioana.ciornei@....com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Wei Fang <wei.fang@....com>, Clark Wang <xiaoning.wang@....com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev
Subject: Re: [PATCH net-next 3/3] net: enetc: convert to use
 .get_rx_ring_count

On Fri, Nov 28, 2025 at 05:11:47AM -0800, Breno Leitao wrote:
> Convert the enetc driver to use the new .get_rx_ring_count
> ethtool operation instead of implementing .get_rxnfc for handling
> ETHTOOL_GRXRINGS command. This simplifies the code in two ways:
> 
> 1. For enetc_get_rxnfc(): Remove the ETHTOOL_GRXRINGS case from the
>    switch statement while keeping other cases for classifier rules.
> 
> 2. For enetc4_get_rxnfc(): Remove it completely and use
>    enetc_get_rxnfc() instead.
> 
> Now on, enetc_get_rx_ring_count() is the callback that returns the
> number of RX rings for enetc driver.
> 
> Also, remove the documentation around enetc4_get_rxnfc(), which was not
> matching what the function did(?!).
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Simon Horman <horms@...nel.org>