linux-kernel - Re: [PATCH net-next v2] selftests: mptcp: Mark xerror _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4656eca-3c65-407b-a487-0a1816c38036@kernel.org>
Date: Sun, 30 Nov 2025 18:09:18 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>,
 Ankit Khushwaha <ankitkhushwaha.linux@...il.com>
Cc: Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
 mptcp@...ts.linux.dev, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] selftests: mptcp: Mark xerror __noreturn

Hi Jakub, Ankit,

On 30/11/2025 02:41, Jakub Kicinski wrote:
> On Sat, 29 Nov 2025 19:13:08 +0100 Matthieu Baerts wrote:
>>> +$(OUTPUT)/mptcp_connect: CFLAGS += -I$(top_srcdir)/tools/include
>>> +$(OUTPUT)/mptcp_sockopt: CFLAGS += -I$(top_srcdir)/tools/include
>>> +$(OUTPUT)/mptcp_inq: CFLAGS += -I$(top_srcdir)/tools/include  
> 
> I believe this is being added via MM or kselftest tree at level of the
> main ksft makefile. Since this is a false positive, maybe let's defer
> fixing the issue until after the merge window? When the -I.. flag
> will be implicitly in place?

@Jakub: Thank you for sharing this, I didn't know about that. That makes
sense to wait.

@Ankit: do you mind sending a v3 without the modifications of the
Makefile, and supporting die_perror() in a bit more than 2 weeks or
later, please?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.