linux-kernel - Re: [PATCH] usb: linux/usb.h: Correct the description of the usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89c7cb17-c5bd-47e6-96b8-1108966b545d@rowland.harvard.edu>
Date: Mon, 1 Dec 2025 10:14:04 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: Yi Cong <cong.yi@...ux.dev>
Cc: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, yicong@...inos.cn
Subject: Re: [PATCH] usb: linux/usb.h: Correct the description of the
 usb_device_driver member

On Mon, Dec 01, 2025 at 04:53:09PM +0800, Yi Cong wrote:
> From: Yi Cong <yicong@...inos.cn>
> 
> In the current kernel USB device driver code, only the name field is
> required to be provided; all other fields are optional.
> Use the command grep -rnw "struct usb_device_driver" to inspect
> how specific drivers are declared.

That last sentence should not be part of the patch description; it 
doesn't explain the patch's purpose or what the patch does.  (It's not 
even correct, because the grep output doesn't show how the specific 
drivers are declared.  It mainly shows the filenames and line numbers 
where the declarations start.)

Aside from that,

Acked-by: Alan Stern <stern@...land.harvard.edu>

Alan Stern

> Correct this part of the description.
> 
> Signed-off-by: Yi Cong <yicong@...inos.cn>
> ---
>  include/linux/usb.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index e85105939af8e..fbfcc70b07fbe 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -1295,8 +1295,7 @@ struct usb_driver {
>   *	resume and suspend functions will be called in addition to the driver's
>   *	own, so this part of the setup does not need to be replicated.
>   *
> - * USB drivers must provide all the fields listed above except driver,
> - * match, and id_table.
> + * USB device drivers must provide a name, other driver fields are optional.
>   */
>  struct usb_device_driver {
>  	const char *name;
> -- 
> 2.25.1
> 
>