linux-kernel - Re: [PATCH v2 4/9] arm64: dts: rockchip: Add power-domain to RK3368 DSI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19a9498e-c8d1-4e1c-b89d-8d1a7e6aa54a@cherry.de>
Date: Mon, 1 Dec 2025 16:23:46 +0100
From: Quentin Schulz <quentin.schulz@...rry.de>
To: Heiko Stuebner <heiko@...ech.de>
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andy.yan@...k-chips.com,
 dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, cn.liweihao@...il.com,
 Heiko Stuebner <heiko.stuebner@...rry.de>
Subject: Re: [PATCH v2 4/9] arm64: dts: rockchip: Add power-domain to RK3368
 DSI controller

Hi Heiko,

On 10/21/25 9:42 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
> 
> The DSI controller is also part of the VIO power-domain and it
> definitely needs to be on when accessing it to not cause SError
> faults, so add the power-domains property to it.
> 
> Fixes: 5023d0cd6183 ("arm64: dts: rockchip: Add DSI for RK3368")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>
> ---
>   arch/arm64/boot/dts/rockchip/rk3368.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index 8f0216203241..5b2cbb3003b6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -896,6 +896,7 @@ mipi_dsi: dsi@...60000 {
>   		clock-names = "pclk";
>   		phys = <&dphy>;
>   		phy-names = "dphy";
> +		power-domains = <&power RK3368_PD_VIO>;

Shouldn't we have the same for the PHY as well?

It's not entirely clear to me as pclk_dphytx0_phy seems to belong to 
PD_ALIVE according to page 62 of TRM v1.1, but Table 4-1 RK3368 Power 
Domain and Voltage Domain Summary doesn't seem to confirm that.

Cheers,
Quentin