linux-kernel - Re: [PATCH] rust: acpi: replace manual zero-initialization with `pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DEMKDP6SAN8X.2W77GYK34BQX0@nvidia.com>
Date: Mon, 01 Dec 2025 12:36:22 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Atharv Dubey" <atharvd440@...il.com>, <rafael@...nel.org>,
 <lenb@...nel.org>
Cc: <ojeda@...nel.org>, <alex.gaynor@...il.com>, <boqun.feng@...il.com>,
 <gary@...yguo.net>, <bjorn3_gh@...tonmail.com>, <lossin@...nel.org>,
 <a.hindborg@...nel.org>, <aliceryhl@...gle.com>, <tmgross@...ch.edu>,
 <dakr@...nel.org>, <linux-acpi@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: acpi: replace manual zero-initialization with
 `pin_init::zeroed()`

On Sat Nov 29, 2025 at 9:27 PM JST, Atharv Dubey wrote:
> Use `pin_init::zeroed()` instead of `core::mem::zeroed()` for initializing
> `acpi_device_id`. This removes an explicit unsafe block and aligns ACPI
> initialization with the pin-init conversion used across the Rust tree.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Signed-off-by: Atharv Dubey <atharvd440@...il.com>
> ---
>  rust/kernel/acpi.rs | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/rust/kernel/acpi.rs b/rust/kernel/acpi.rs
> index 37e1161c1298..9b8efa623130 100644
> --- a/rust/kernel/acpi.rs
> +++ b/rust/kernel/acpi.rs
> @@ -39,9 +39,7 @@ impl DeviceId {
>      pub const fn new(id: &'static CStr) -> Self {
>          let src = id.to_bytes_with_nul();
>          build_assert!(src.len() <= Self::ACPI_ID_LEN, "ID exceeds 16 bytes");
> -        // Replace with `bindings::acpi_device_id::default()` once stabilized for `const`.

Let's keep this comment as well.